Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change module path to v4 per go conventions #750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change module path to v4 per go conventions #750

wants to merge 1 commit into from

Conversation

jeffwidman
Copy link

@jeffwidman jeffwidman commented Apr 12, 2024 •
edited

For major versions > 1, the go convention is that the module path should have a suffix with the major version.

Since the published version is currently 4.4.2, that means it should be /v4

Fix: #652

@jeffwidman
Change module path to v4 per go conventions
26f56f8 
For major versions > 1, the `go` convention is that the module path should have a suffix with the major version.

Since the published version is currently `4.4.2`, that means it should be `/v4`

More details here: 
* cheat#652 (comment)
@jeffwidman jeffwidman mentioned this pull request Apr 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module should be github.com/cheat/cheat/v4 for Go's indexing servers to pick it up
1 participant
@jeffwidman