Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: error message changed when code has been already applied #871

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nahuelDev23
Copy link

Issue link / number:

816

What changes did you make?

I have changed the error messages for the ApplyCodeForm.tsx component, both for English and Spanish languages.

Why did you make the changes?

Because it was a requirement.

Copy link

vercel bot commented Apr 5, 2024

@nahuelDev23 is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

@nahuelDev23
Copy link
Author

@eleanorreem

@kyleecodes kyleecodes self-assigned this Apr 7, 2024
@kyleecodes
Copy link
Member

Hi @nahuelDev23, thank you for your PR.
May you comment on the issue so I can assign it to you? This helps us keep track of contributions.
I've also tagged a reviewer for your PR.

Copy link
Member

@annarhughes annarhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution Nahuel 🌟 Looks almost good to go, it would be great to add placeholder strings for the other 4 languages, so it doesn't error in that language. We can use the english string for now!

Looks like some rouge package-lock.json and yarn.lock changes snook in. Could we undo those as they may cause clashes!

@kyleecodes
Copy link
Member

Hey @nahuelDev23 👋

Pinging you again to see if you're still interested in completing your contribution?
To merge your PR, please refer to the comments above so we can get you assigned to the correct issue and remove the lockfiles.
Once those are completed we can move forward. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants