Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpful error message when applying a code that already exists #816

Open
5 tasks
eleanorreem opened this issue Jan 11, 2024 · 4 comments
Open
5 tasks

Helpful error message when applying a code that already exists #816

eleanorreem opened this issue Jan 11, 2024 · 4 comments
Assignees
Labels
complexity: beginner Time needed to do this ticket is less than 1 day. feature/enhancement New feature or request help wanted Extra attention is needed stale This issue or PR is inactive state: blocked Task is blocked.

Comments

@eleanorreem
Copy link
Contributor

eleanorreem commented Jan 11, 2024

Overview

Please note that this ticket is blocked by this backend ticket

When a user is logged in they can apply a code on this form on /account/apply-a-code. However, if they accidentally apply the code twice, they get this unhelpful error message.

Screenshot 2024-01-11 at 13 37 28

This is not the best and doesn't let the user know that they have already applied the code and don't need to do anything else.

The solution is:

  • the backend will return a new error message ALREADY_APPLIED
  • If the frontend receives this error, the message should read: 'This code has already been applied to your account'

Action Items

  • Pull develop to ensure you have the most recent code
  • Create your own branch
  • Add ALREADY_APPIED to the enum PARTNER_ACCESS_CODE_STATUS in enums.ts
  • Ensure that the frontend displays the right message 'This code has already been applied to your account' when the error code matched ALREADY_APPLIED. The file you will need to modify is /bloom-frontend/components/forms/ApplyCodeForm.tsx
  • Create a PR and tag @eleanorreem .

Resources/Instructions

@eleanorreem eleanorreem added the complexity: beginner Time needed to do this ticket is less than 1 day. label Jan 11, 2024
@kyleecodes kyleecodes added the help wanted Extra attention is needed label Feb 5, 2024
@kyleecodes kyleecodes added state: blocked Task is blocked. feature/enhancement New feature or request labels Mar 25, 2024
@mayank-sahai
Copy link
Contributor

@eleanorreem @kyleecodes i would like to work on this one too. as i have requested to work on the backend task linked to it as well. thanks

Copy link
Contributor

Thank you for your interest in contributing to Chayn! Please carefully read the CONTRIBUTING.md file and the README.md file for guidance. Let us know if you have any questions. Good luck!

@chaynHQ chaynHQ deleted a comment from github-actions bot Apr 24, 2024
@kyleecodes
Copy link
Member

@mayank-sahai thank you for your interest and for looking into the backend issue too!
I've assigned you this issue and I've pinged the devs to answer your question in the backend problem.
Happy coding! 😊

Copy link
Contributor

github-actions bot commented May 1, 2024

As per Chayn policy, after 60 days of inactivity, we will be unassigning this issue to open it back up for contributors. Please comment to be re-assigned. Thank you for your interest in contributing to Chayn!

@github-actions github-actions bot added the stale This issue or PR is inactive label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: beginner Time needed to do this ticket is less than 1 day. feature/enhancement New feature or request help wanted Extra attention is needed stale This issue or PR is inactive state: blocked Task is blocked.
Projects
None yet
Development

No branches or pull requests

3 participants