Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around for flakey code coverage reporting #741

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/next-drupal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ jobs:
with:
ref: ${{github.event.pull_request.head.ref}}
repository: ${{github.event.pull_request.head.repo.full_name}}
# TODO: Work-around for failing code coverage.
# https://github.com/chapter-three/next-drupal/issues/740
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '18.19.x'
- name: Install packages
run: yarn
- name: Run tests
Expand Down
6 changes: 5 additions & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
v18
v18.19

# @TODO v18.20 and v20.10 and later have a bug that causes Jest code coverage to randomly fail. When the tracking bug is fixed, switch to the less-specific "v18" or "v20" version. See https://github.com/chapter-three/next-drupal/issues/740

# Note: This is a non-standard .nvmrc comment. Currently, nvm ignores all lines except the 1st line so we are hijacking this implementation detail to add comments to this file. See https://github.com/nvm-sh/nvm/pull/2288#issuecomment-1115079020
Loading