feat(next-drupal): translatePath, getResourceByPath - throw error when backend error #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n backend error Until now, any not-ok response from decoupled router was treated equally, as a 404 Not Found. Behaviour is changed differentiating between 404 Not Found and server error. The advantage is frontend holds to previous built page and doesn't update public page content with a 404 due to backend issues. BREAKING CHANGE: Might break sites relying on response being the same in 404 than in 50x. Fixes chapter-three#687
|
Someone is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, any not-ok response from decoupled router was treated equally, as a 404 Not Found. Behaviour is changed differentiating between 404 Not Found and server error. The advantage is frontend holds to previous built page and doesn't update public page content with a 404 due to backend issues.
BREAKING CHANGE:
Might break sites relying on response being the same in 404 than in 50x.
Fixes #687
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterGitHub Issue: #
Please add a link to the GitHub issue
where this problem is discussed.
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
A clear and concise description of what the request is.
If applicable, add screenshots to help explain your issue.