WIP: quick test of rebase of 665 #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
The DrupalClient class has been renamed to NextDrupalPages and has been refactored to inherit from the NextDrupalBase (base class) and NextDrupal (JsonAPI/App Router class). NextDrupalPages class contains the methods that are only needed to support Next.js' Pages Router. NextDrupalPages is also available as "DrupalClient" for backwards-compatibility. The getPathFromContext() method has been replaced with the constructPathFromSegment() method for App Router usages. Issue #665
…ticParams() The App Router's new generateStaticParams() replaces Pages Router's getStaticProps(). The new getResourceCollectionPathSegments() method supports generateStaticParams() by returning a list of path segments. This new method replaces the old getStaticPathsFromContext() method. Fixes #665
…ctionPathSegments() Issue #665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting strange test results locally and want to run the rebased code agains the CI.