Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "slug" with "path" in draft/revalidate URLs #719

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

JohnAlbin
Copy link
Collaborator

@JohnAlbin JohnAlbin commented Mar 10, 2024

This pull request is for:

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter

GitHub Issue: #718

Describe your changes

Replaces "slug" with "path" in revalidate/preview/draft URLs.

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 5:10pm

@JohnAlbin JohnAlbin changed the title Use "Dynamic Path Segment" or "path" instead of "slug" Replace "slug" with "path" in draft/revalidate URLs Mar 10, 2024
@JohnAlbin JohnAlbin force-pushed the 718-fix-slug-problem branch 4 times, most recently from c04a381 to e7aed48 Compare March 11, 2024 18:27
@JohnAlbin JohnAlbin mentioned this pull request Mar 11, 2024
2 tasks
…te urls

BREAKING CHANGE:
When Drupal uses the Preview Url and the Revalidate Url, the "slug" search param
has been renamed to "path".

Fixes #718
@JohnAlbin JohnAlbin marked this pull request as ready for review March 15, 2024 17:19
Copy link
Member

@robdecker robdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@JohnAlbin JohnAlbin merged commit 4bce663 into main Mar 15, 2024
11 checks passed
@JohnAlbin JohnAlbin deleted the 718-fix-slug-problem branch March 15, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants