Allow 1.x and 2.x of "cweagans/composer-patches". #705
Conversation
|
@rajeshreeputra is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
The installation instructions for Next Drupal already include requiring composer-patches to the Drupal project using the Next module. From https://next-drupal.org/learn/quick-start/apply-patches
That means this require line in the module's composer.json is redundant/can conflict with with the Drupal project's composer.json.
I think the proper fix to support either 1.x or 2.x of composer-patches is to remove the "cweagans/composer-patches": "~1.0", line from modules/next/composer.json
rajeshreeputra
force-pushed
the
patch-2
branch
from
d1c1f71
to
7fef2ff
Compare
|
Yes, it only makes sense to support the |
|
That make more sense to me and that will be great, thank you. |
|
Considering your availability, can we anticipate the release on Drupal.org in a couple of weeks. Thank you! |
|
@JohnAlbin can get this released on Drupal.org, thank you! |
+1 |
|
@rajeshreeputra @vishalkhode1 It's been on Drupal.org since March 12. https://www.drupal.org/project/next/releases/2.x-dev Also, a new alpha or beta release will be made in the next couple weeks. |
This pull request is for: (mark with an "x")
modules/nextGitHub Issue: #704
Please add a link to the GitHub issue
where this problem is discussed.
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
Allow "cweagans/composer-patches" both versions i.e. 1.x and 2.x.