Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public debug() method to DrupalClient #669

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Add public debug() method to DrupalClient #669

merged 2 commits into from
Jan 29, 2024

Conversation

JohnAlbin
Copy link
Collaborator

@JohnAlbin JohnAlbin commented Jan 29, 2024

This pull request is for:

  • packages/next-drupal

GitHub Issue: #668

Describe your changes

In the DrupalClient, this changes the internal _debug() method to a public debug() method. It also changes a previously public debug property (boolean) to an internal property.

This PR also fixes some code formatting in the first commit.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 3:16pm

Fixes #668

BREAKING CHANGE:
DrupalClient previously had a debug property that indicated if debugging was
enabled. This property has been removed and replaced with a debug() method that
accepts a string and logs it as a debug message if debugging is enabled.
Copy link
Member

@robdecker robdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohnAlbin JohnAlbin merged commit e0fc4bd into main Jan 29, 2024
13 checks passed
@JohnAlbin JohnAlbin deleted the 668-public-debug branch January 29, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants