Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing 'preview_enabled' on the next_entity_type_config entity #660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bojanbogdanovic
Copy link
Contributor

@bojanbogdanovic bojanbogdanovic commented Jan 18, 2024

This pull request is for: (mark with an "x")

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter
  • Other

GitHub Issue: #496

Describe your changes

I have decoupled the site resolver from preview mode in the 'next_entity_type_config' and added a new 'preview_enabled' property. This property gives the ability to enable/disable the preview mode on specific entities. The site resolver is now also required, due the fact that it is needed for the preview mode and on demand revalidation.

Screenshot of the UI change:
Screenshot 2024-01-18 at 11 28 15

Copy link

vercel bot commented Jan 18, 2024

@bojanbogdanovic is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

@jeffschuler
Copy link

This is working for us, and very much needed. Thanks @bojanbogdanovic!

Here are the changes as a patch for the Next module in Drupal:
next_drupal-660-5c0d143.patch

@JohnAlbin
Copy link
Collaborator

Merge conflicts with a previous PR need to be resolved. Sorry about that!

@bojanbogdanovic
Copy link
Contributor Author

Bump! Merge conflict is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants