Add code formatting and linting tests #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JohnAlbin
force-pushed
the
573-test-linting
branch
from
9e01788
to
2d4ee6e
Compare
JohnAlbin
force-pushed
the
573-test-linting
branch
from
d5ff6d6
to
4bba890
Compare
JohnAlbin
force-pushed
the
573-test-linting
branch
from
4bba890
to
a2b740e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterGitHub Issue: #573
Describe your changes
Performs eslint linting and prettier code formatting checks before running other test suites.
I've update the prettier config to use the Drupal core config for JS files in /modules/next. And I've simplified the prettier config because most of the specified values were the default config values.
Upgrading to Prettier v3 required replacing the abandoned pretty-quick with lint-staged and bumping the Node.js version in the CI and locally to v18 as lint-staged doesn't work on v16.
There are a bunch of file changes that are simply fixing prettier formatting and eslint errors.