Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify callbacks #862

Merged
merged 17 commits into from
Sep 13, 2023
Merged

refactor: unify callbacks #862

merged 17 commits into from
Sep 13, 2023

Conversation

segunadebayo
Copy link
Member

📝 Description

This PR unifies callbacks to follow a consistent naming convention.

  • onOpen / onClose => onOpenChange
  • onChange => onValueChange
  • onHighlight => onHighlightChange

⛳️ Current behavior (updates)

Quite inconsistent across machines

🚀 New behavior

Now consistent

💣 Is this a breaking change (Yes/No):

Yes

📝 Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

🦋 Changeset detected

Latest commit: 60c99fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@zag-js/color-picker Minor
@zag-js/number-input Minor
@zag-js/range-slider Minor
@zag-js/rating-group Minor
@zag-js/toggle-group Minor
@zag-js/date-picker Minor
@zag-js/file-upload Minor
@zag-js/radio-group Minor
@zag-js/hover-card Minor
@zag-js/pagination Minor
@zag-js/tags-input Minor
@zag-js/accordion Minor
@zag-js/pin-input Minor
@zag-js/carousel Minor
@zag-js/checkbox Minor
@zag-js/combobox Minor
@zag-js/editable Minor
@zag-js/presence Minor
@zag-js/splitter Minor
@zag-js/popover Minor
@zag-js/tooltip Minor
@zag-js/avatar Minor
@zag-js/dialog Minor
@zag-js/select Minor
@zag-js/slider Minor
@zag-js/switch Minor
@zag-js/menu Minor
@zag-js/tabs Minor
@zag-js/types Minor
@zag-js/react Minor
@zag-js/solid Minor
@zag-js/vue Minor
@zag-js/pressable Minor
@zag-js/toast Minor
@zag-js/dom-event Minor
@zag-js/dismissable Minor
@zag-js/focus-scope Minor
@zag-js/interact-outside Minor
@zag-js/anatomy-icons Minor
@zag-js/anatomy Minor
@zag-js/core Minor
@zag-js/docs Minor
@zag-js/store Minor
@zag-js/aria-hidden Minor
@zag-js/auto-resize Minor
@zag-js/collection Minor
@zag-js/color-utils Minor
@zag-js/utils Minor
@zag-js/date-utils Minor
@zag-js/dom-query Minor
@zag-js/element-rect Minor
@zag-js/element-size Minor
@zag-js/file-utils Minor
@zag-js/focus-visible Minor
@zag-js/form-utils Minor
@zag-js/live-region Minor
@zag-js/mutation-observer Minor
@zag-js/number-utils Minor
@zag-js/numeric-range Minor
@zag-js/popper Minor
@zag-js/rect-utils Minor
@zag-js/remove-scroll Minor
@zag-js/tabbable Minor
@zag-js/text-selection Minor
@zag-js/visually-hidden Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Sep 13, 2023 6:03pm
zag-solid ✅ Ready (Inspect) Visit Preview Sep 13, 2023 6:03pm
zag-vue ✅ Ready (Inspect) Visit Preview Sep 13, 2023 6:03pm
zag-website ✅ Ready (Inspect) Visit Preview Sep 13, 2023 6:03pm

@github-actions
Copy link
Contributor

Visualize the logic of the machines here 🎊

Copy link
Member Author

@segunadebayo segunadebayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Review: Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant