Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dismissable): use observeChildren to assign pointer-events: auto #1842

Closed
wants to merge 2 commits into from

Conversation

tsukkee
Copy link
Contributor

@tsukkee tsukkee commented Sep 11, 2024

Closes #1840

📝 Description

use observeChildren (means utilizing MutationObserver) to assign pointer-events: auto to elements which are indicated by persistentElements parameter of Dialog, Popover, and other components using dismissable.

⛳️ Current behavior (updates)

pointer-events: auto is assigned to the elements only once after the component is appended.

🚀 New behavior

pointer-events: auto is always assigned to the elements every time they are appended.

💣 Is this a breaking change (Yes/No):

No.

📝 Additional Information

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: 3263b4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-solid ✅ Ready (Inspect) Visit Preview Sep 12, 2024 5:16am
zag-svelte ✅ Ready (Inspect) Visit Preview Sep 12, 2024 5:16am
zag-vue ✅ Ready (Inspect) Visit Preview Sep 12, 2024 5:16am
zag-website ✅ Ready (Inspect) Visit Preview Sep 12, 2024 5:16am

Copy link

vercel bot commented Sep 11, 2024

@tsukkee is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Sep 11, 2024

Open in Stackblitz

@zag-js/anatomy

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/anatomy@1842

@zag-js/anatomy-icons

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/anatomy-icons@1842

@zag-js/core

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/core@1842

@zag-js/docs

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/docs@1842

@zag-js/store

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/store@1842

@zag-js/types

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/types@1842

commit: 3263b4e

@segunadebayo
Copy link
Member

Closing based on #1840 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants