fix(combobox): highlight values remain when items changed #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac4e204 The changes in this PR will be included in the next version bump. This PR includes changesets to release 75 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@erm1116 is attempting to deploy a commit to the Chakra UI Team on Vercel. A member of the Team first needs to authorize it. |
@zag-js/anatomy
@zag-js/anatomy-icons
@zag-js/docs
@zag-js/core
@zag-js/store
@zag-js/types
commit: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
In Combobox, when we want to display something like
no optionwhen filtering by input, an unintended highilghtedValue is kept in the internal state.This would cause an empty item (like value=‘something’, item=null) to be selected, so this issue has been fixed.
⛳️ Current behavior (updates)
CleanShot.2024-09-11.at.12.00.02.mp4
🚀 New behavior
When items changed (in other word, to change the children node), forced update the highlighted value.
This ensures that the highlight value is not an unintended,
because the value of
ctx.collection.firstValuewill be null if items is not present and null will be forced set.CleanShot.2024-09-11.at.12.01.57.mp4
💣 Is this a breaking change (Yes/No):
📝 Additional Information
I thought about preventing value changes when item=null, but I thought that the problem was that the highlight was still remain so I fix like this PR.