Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presence): set initial context #1124

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

iamdin
Copy link
Contributor

@iamdin iamdin commented Dec 30, 2023

Closes #

📝 Description

Add a brief description

fixed not set initial context for presence

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

the usecase:

  const [state, send] = useMachine(
    presence.machine({
      ...context.value,
      onExitComplete: () => {
        emit('exit-complete')
      },
    }),
    // the below context don't include onExitComplete anymore
    { context },
  )

if i passed onExitComplete as initial context to useMachine, the onExitComplete won't call correctly

🚀 New behavior

Please describe the behavior or changes this PR adds

set initial context for presence

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

Copy link

changeset-bot bot commented Dec 30, 2023

⚠️ No Changeset found

Latest commit: 08de7eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-nextjs ✅ Ready (Inspect) Visit Preview Dec 30, 2023 4:47am
zag-solid ✅ Ready (Inspect) Visit Preview Dec 30, 2023 4:47am
zag-vue ✅ Ready (Inspect) Visit Preview Dec 30, 2023 4:47am
zag-website ✅ Ready (Inspect) Visit Preview Dec 30, 2023 4:47am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants