Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(use-outside-click) change mouse to pointer events #8189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nightbr
Copy link

@Nightbr Nightbr commented Jan 4, 2024

📝 Description

  • To make it works with some Graph library (Reactflow) that prevent mouseUp/mouseDown events

⛳️ Current behavior (updates)

  • When clicking outside, on some cases (on Reactflow Graph for example) when the mouseUp/mouseDown events are prevented, the menu will not close

🚀 New behavior

  • In every case, the click outside works and the menu it closed properly

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chakra-ui-storybook ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:33pm

Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: 81b89b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@chakra-ui/react-use-outside-click Patch
@chakra-ui/menu Patch
@chakra-ui/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

- To make it works with some Graph library (Reactflow) that prevent mouseUp/mouseDown events
@Nightbr Nightbr changed the title use-outside-click change mouse to pointer events fix(use-outside-click) change mouse to pointer events Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant