Resolved JsCreateString & JsPointerToString #6669 #6739
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I am new to Open-Source, I picked this issue. Following the instructions, I have:
Changed the SAL annotation for the string input parameter from In to In_opt, I also read up relevant documentation for the same which helped in understanding NULL Value handling.
I have also changed the implementation, added the test cases & updated the comments in the headers which mention that 0 lengths will ignore the input string pointer and return a Js empty string.
The Added test cases that were previously not working are working now.
I also glanced through the active contributions for the same issue by @dagarxji, and tried to solve the last issue raised by @rhuanjl regarding the PERFORM_JSRT_TTD_RECORD_ACTION macro & checked in case it is inside an if-conditional.
I spent a majority of my time understanding Chakra & the code-flow, the thought behind has been really instructional. Already loving the inclusivity of the community.