Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show class colour and filter points by class in segmentation model #138

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chingyulin
Copy link
Collaborator

@chingyulin chingyulin commented Mar 22, 2023

This PR introduces a section to show the segmentation color and check boxes to adjust points visibility and assignablility.

The color is useful to remind the annotator of the existing labelled points.
The filter is useful to hide labelled points to reduce cognitive load.

UI:
image

Demo:

  1. Raw color filtering:
    raw_color_filter

  2. Mix color filtering:
    mix_color_filter

  3. Assign labels only to visible points
    Screen Recording 2023-03-23 at 19 00 08

@chingyulin chingyulin requested a review from ch-sa March 22, 2023 21:07
@chingyulin chingyulin marked this pull request as ready for review March 22, 2023 21:09
@ch-sa
Copy link
Owner

ch-sa commented Mar 26, 2023

Hi @chingyulin,

thanks for the effort. I think though that making a whole table out of the label list adds a bit too much clutter to the UI.

However, I like the idea with hiding the labeled points.

What about ...

  1. adding only a very subtle hide icon on the right side besides the label text (see icon)
    eye-off-outline
  2. only coloring the bounding box icon in the color of the class (here blue)

label-list-proposal

@chingyulin
Copy link
Collaborator Author

Hi @ch-sa,

Thank you for the comments.

  • I like the eye icon for controlling the visibility, will use it.

  • The reason why it is needed to have a new table for segmentation and not to use bounding box table for it is because there can be multiple bounding boxes having the same class. If we use the box table for controlling the visibility of classes, multiple boxes could control the same class, which could cause confusion. I agree that adding a table will clutter the UI under segmentation mode but I don't know a good way to avoid it without changing the bounding box table functionality. In terms of the segmentation workflow, it is not necessary that the bounding box table can have boxes with the same class as is because one would normally just create a box, assign the points in the box with the class, destroy the box; and move on to creating a new box. That is at any given point, there is at most one box in the canvas. However, it would require to repurpose the bounding box table and maybe even rethink about the UI workflow for segmentation. What do you think?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants