Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some functions when using cgreen with its namespace in C++. #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TommyJC
Copy link
Contributor

@TommyJC TommyJC commented Jan 7, 2024

Hello,

Using cgreen for C++ without including using namespace cgreen in the code results in compilation errors when one attempts to use cgreen::assert_that().

I just prefixed some things with cgreen:: and added namespace cgreen { where appropriate.

The changes from this patch fixed the parts of cgreen I utilized but I haven't been able to test everything in cgreen.

Ideally I wanted to add the cgreen namespace to TestSuite in include/cgreen/internal/suite_internal.h as well but since that has namespace cgreen { later, I take it there was a good reason not to add TestSuite to the cgreen namespace.

Those who are applying using namespace cgreen to get around the compilation error should see no difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant