Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design Review] Sign & Submit #524

Merged
merged 11 commits into from
May 21, 2024
Merged

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented May 15, 2024

Close #449

Changes

  • Content updates

Screenshots - Updated May 16, 12:30 ET

screencapture-localhost-8899-filing-2024-123456789TESTBANK123-submit-2024-05-16-10_26_44

Copy link

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meissadia
This page is looking good! I reviewed on AWS and I have a few tiny content fixes, one spacing fix, and a line length fix.

  • In the "Confirm your parent entity" section
    • Adjust the space above and below the rule line to 30px.
  • In "Confirm your filing point of contact"
    • Add comma - "If the information in this section is incorrect,"
  • In "Confirm your register information"
    • Add comma - "If the information in this section is incorrect,"
    • Change "PM" to "p.m."
  • In the success message:
    • Change body text to 670px wide
    • Change heading from "our" to "the" -- Congratulations! You have reached the end of the beta filing process.

Date and time

What I mention here is not necessary for MVP but something I'd like to better understand in terms of how we've set this up.

I pulled these related guidelines from our editorial style guide:

  • When a month is used with a specific date, abbreviate Jan., Feb., Aug., Sep., Oct., Nov., and Dec., but not March, April, May, June, and July
  • For time, Use lowercase a.m. and p.m., with periods
  • Include a space between the time (number) and the a.m. or p.m.
  • If it’s an exact hour, do not include “:00″
  • Abbreviate the time zone when it appears with a specific time. To simplify time zones and Daylight Saving Time, use ET, CT, MT, or PT to indicate Eastern time, Central time, etc.

It may be that in code we can't adjust for all of these things but I did want to share this information as we try to standardize how we handle this type of data on the platform.

@meissadia meissadia mentioned this pull request May 16, 2024
5 tasks
@meissadia
Copy link
Collaborator Author

@natalia-fitzgerald All updated.

Follow-up ticket for Date/time here: #531

@meissadia meissadia dismissed natalia-fitzgerald’s stale review May 20, 2024 16:09

Requested changes implemented

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for all the detailed work here. 👍

@meissadia meissadia merged commit e3a2f38 into main May 21, 2024
4 checks passed
@meissadia meissadia deleted the 449-design-review__sign-submit branch May 21, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design Review] Sign & submit
3 participants