feat(a11y): add axe core test to unauthenticated landing page #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhimmelsbach
changed the title
Closes #376 Easy command to run Cypress against local without changing ENV vars or config files yarn test:e2e:headless:local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have to run accessibility tests locally via extensions or CLI tools, but
axe-corecould run right next to our other cypress tests.Changes
axe-coreandaxe-cypressdesign-system-reactwith latest changesHow to test this PR
Screenshots
With an accessibility error (header is a div instead of semantic html)
Without an accessibility error (semantic header fixed in DSR)
Notes