Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate-explorer tests for some dynamic content #7633

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 29, 2023

Touching rate-explorer scares me, let's have some tests for the dynamically displayed drop-downs and alerts.

Additions

  • Add a few more rate-explorer tests to test the different loan types dynamic drop-downs and alerts.

How to test this PR

  1. yarn cypress open to test manually.
  2. PR checks should pass.

@anselmbradford
Copy link
Member Author

So turns out this is blocked by there not being example data for the rate checker API in our test data, which is what the Cypress tests run against in GitHub Actions.

@anselmbradford
Copy link
Member Author

Use [ghe]/OAH/OAH-notes/wiki/Explore-Rates-high-balance-logic as a guide to building out test suite.

@anselmbradford
Copy link
Member Author

Flagging @wpears and @mistergone if they get into adding additional test data to rate-explorer and need some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants