Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Feature/simplify pixelbypixelcomparisonstrategy and adding unit tests #75

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lukasz-pekala
Copy link
Contributor

@lukasz-pekala lukasz-pekala commented Nov 9, 2020

Most important changes are:

  • Fix bug: New patterns were not added to db due to invoking screenshot ComparisonStrategy.Compare(...) with null value.
  • Switching from double to decimal, using a precision of 2 digits after a comma

@cezarypiatek Kind code review request

@lukasz-pekala
Copy link
Contributor Author

@cezarypiatek Any chances to accept this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant