Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test CI #228

Closed
wants to merge 12 commits into from
Closed

chore: test CI #228

wants to merge 12 commits into from

Conversation

JulissaDantes
Copy link
Contributor

@JulissaDantes JulissaDantes commented Jul 25, 2024

PR to test CI

TODO

  • Remove random word post CI fix

@JulissaDantes
Copy link
Contributor Author

Since the only change was to update a test name, from the CI runs on the 6135edf commit we know something is wrong in the CI, probably after a external change in either github environment or one of out dependencies.

@JulissaDantes JulissaDantes marked this pull request as ready for review July 25, 2024 18:12
@JulissaDantes JulissaDantes requested a review from PaulLeCam July 25, 2024 18:12
Copy link
Contributor

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strange to me we'd have to explicitly add this to the CI setup to have it work.
Assuming the issue comes from a dependency, could you try importing the changes from #226 in your branch instead, or maybe we can merge #226 if you can approve it and you can pull the main branch in #227, what do you think?

@JulissaDantes
Copy link
Contributor Author

Seems strange to me we'd have to explicitly add this to the CI setup to have it work. Assuming the issue comes from a dependency, could you try importing the changes from #226 in your branch instead, or maybe we can merge #226 if you can approve it and you can pull the main branch in #227, what do you think?

Yes, I'll try approving the release and then importing the changes to #227 , I also thought it was weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants