Fix unable to open Valora on iOS #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jeanregisser Thanks for propagating this change. Support for Universal Links will be coming soon for RainbowKit Connectors after a refactor that allows us to proactively fetch the WalletConnect URI, whereas in WalletConnect v1, we were able to fetch the URI immediately at the time a user initiates a connection (taps a wallet). Essentially a change to WalletConnect that has just bubbled up and requires us to more aggressively pre-fetch before a user attempts a connection. Will make sure the API is non-breaking and will document with proper release notes! |
nicolasbrugneaux
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue observed in #47 (comment)
It's now using the direct deeplink for Valora.
@DanielSinclair put me in the right direction with this in rainbow-me/rainbowkit#1336 (comment)
I'm still not entirely sure why universal links can't be used, but this is what Omni, Argent, Trust Wallet and all the other wallets listed in RainbowKit are doing since the v2 upgrade.
Confirmed it works locally.