chore: add end-to-end test for ApiGatewayV2 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colifran
reviewed
Apr 4, 2024
tests/end-to-end.rs
Outdated
| @@ -84,6 +84,7 @@ test_case!(cloudwatch, "CloudwatchStack", &["golang"]); | |||
| test_case!(ecs, "EcsStack", &["java", "golang"]); | |||
| test_case!(ec2, "Ec2Stack", &["java", "golang"]); | |||
| test_case!(efs, "EfsStack", &["java", "golang"]); | |||
| test_case!(apigatewayv2, "ApiGatewayV2Stack", &["csharp", "golang", "python"]); | |||
There was a problem hiding this comment.
I'm concerned about not synthesizing python and csharp. If these aren't working you may have uncovered a bug. Could you remove these and we can debug the failing tests?
colifran
requested changes
Apr 4, 2024
Codecov Report
Additional details and impacted files
@@ Coverage Diff @@
## main #644 +/- ##
=====================================
Coverage 82.1% 82.1%
=====================================
Files 27 27
Lines 5097 5097
Branches 5097 5097
=====================================
Hits 4186 4186
Misses 741 741
Partials 170 170 Continue to review full report in Codecov by Sentry.
|
rix0rrr
force-pushed
the
main
branch
18 times, most recently
from
36431a5 to
49e93a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.