fix: GitHub release notes fails with ERR_INVALID_CALLBACK (#1050)

The GitHub release notes feature is failing due to an invalid calling pattern against readFile. Fixed the call and verified via a local test that the results match as expected.
cdklabs · Oct 26, 2021 · d16cbd1 · d16cbd1
1 parent 4a2c0ba
commit d16cbd1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/__tests__/expected.yml b/lib/__tests__/expected.yml
@@ -3268,7 +3268,7 @@ Resources:
             Value: cdk-hnb659fds-assets-712950704752-us-east-1
           - Name: SCRIPT_S3_KEY
             Type: PLAINTEXT
-            Value: 168799fb36a5c07de842b73d47e38fc33983aadeec36fca33b73cdc9388dce6a.zip
+            Value: e12c7af9b638ac5f6e69012fdab4a414bd0c107b6a233304e64b443a621ecd20.zip
           - Name: BUILD_MANIFEST
             Type: PLAINTEXT
             Value: ./build.json

diff --git a/lib/publishing/github/create-release.js b/lib/publishing/github/create-release.js
@@ -37,7 +37,7 @@ async function read_release_notes() {
         return undefined;
     }
 
-    return fs.readFile(release_notes_file, 'utf8');
+    return readFile(release_notes_file, { encoding: 'utf8' });
 }
 
 async function read_changelog(version) {