Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First release of the framework #1

Merged
merged 100 commits into from
Jun 6, 2024
Merged

First release of the framework #1

merged 100 commits into from
Jun 6, 2024

Conversation

DeborahVolpe
Copy link
Collaborator

@DeborahVolpe DeborahVolpe commented May 27, 2024

Pull request for obtaining a first mqt-toolkit-compatible release of the framework, adding documentation, managing libraries dependencies, updating code for supporting qiskit 1.0.

src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
src/mqt/qao/solvers.py Fixed Show fixed Hide fixed
scripts/linear_regression/LinearRegression.py Fixed Show fixed Hide fixed
scripts/linear_regression/LinearRegression.py Fixed Show fixed Hide fixed
scripts/Knapsack/Knapsack.py Fixed Show fixed Hide fixed
scripts/Knapsack/Knapsack.py Fixed Show fixed Hide fixed
scripts/Knapsack/Knapsack.py Fixed Show fixed Hide fixed
scripts/Knapsack/Knapsack.py Fixed Show fixed Hide fixed
scripts/Knapsack/Knapsack.py Fixed Show fixed Hide fixed
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very close to the finish line. Just a couple further fixes necessary before it can be merged. Please see the inline comments.

CITATION.bib Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/Constraints.rst Outdated Show resolved Hide resolved
docs/Problem.rst Outdated Show resolved Hide resolved
docs/Solution.rst Show resolved Hide resolved
docs/refs.bib Show resolved Hide resolved
scripts/Knapsack/Knapsack.py Show resolved Hide resolved
scripts/linear_regression/LinearRegression.py Show resolved Hide resolved
@burgholzer burgholzer assigned DeborahVolpe and unassigned burgholzer Jun 6, 2024
@burgholzer
Copy link
Member

Also: Please provide a proper Title, a Description, and the appropriate Labels for this Pull Request.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for all the work 🙏🏼
Overall, this is looking good now and ready to merge ✅

However, #1 (comment) is still left unaddressed. Once that is done and CI has finished, I'll proceed to merge and create a release.

@DeborahVolpe DeborahVolpe added the continuous integration Anything related to the CI setup label Jun 6, 2024
@DeborahVolpe DeborahVolpe changed the title Tests First release of the framework Jun 6, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement Improvement of an existing feature or request github_actions Pull requests that update Github_actions code packaging Anything related to Python packaging python Anything related to Python code labels Jun 6, 2024
@burgholzer burgholzer merged commit 367cba8 into main Jun 6, 2024
9 of 20 checks passed
@burgholzer burgholzer deleted the test branch June 6, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement Improvement of an existing feature or request github_actions Pull requests that update Github_actions code packaging Anything related to Python packaging python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants