Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ ABC Callback #605

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

✨ ABC Callback #605

wants to merge 19 commits into from

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Dec 5, 2024

Description

This PR adds an optional callback to ABC to fiction's CLI.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the enhancement New feature or request label Dec 5, 2024
@marcelwa marcelwa self-assigned this Dec 5, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cli/cmd/io/read.hpp Show resolved Hide resolved
cli/commands.hpp Show resolved Hide resolved
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (a363f8a) to head (774b488).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         232      232           
  Lines       35410    35410           
  Branches     1691     1691           
=======================================
  Hits        34748    34748           
  Misses        660      660           
  Partials        2        2           

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a363f8a...774b488. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

cli/commands.hpp Show resolved Hide resolved
Copy link
Collaborator

@simon1hofmann simon1hofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the addition, just tested the abc callback again and it works without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants