-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ABC Callback #605
base: main
Are you sure you want to change the base?
✨ ABC Callback #605
Conversation
… directly from within the CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 232 232
Lines 35410 35410
Branches 1691 1691
=======================================
Hits 34748 34748
Misses 660 660
Partials 2 2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: Marcel Walter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the addition, just tested the abc
callback again and it works without any issues.
Description
This PR adds an optional callback to ABC to fiction's CLI.
Checklist: