chore: remove unused code #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename method getInsertId into getInsertedId rename method getInsertIdForSequence in getInsertedIdForSequence
Classes which extend CCMBenchmark\Ting\Repository\Hydrator must call parent::__construct() to initialize weakmaps
|
Those are protected methods and not marked as internal, they should not be removed in a minor version but only in 4.0 |
chore: removing deprecated methods
|
@xavierleune, I've changed the target of this PR to 4.X branch |
vgreb
force-pushed
the
chore/remove-uuid-generation
branch
from
5e4946e to
7a8374b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These function are not needed since Weakmap have been introduces in #90