Fix typing for factory #102
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since repositories extend a base class, they can have method that are not in this base class. The issue with using `Repository<T>` as the return type is that PHPStan cannot see those methods. For example: https://phpstan.org/r/65389bf5-b00d-4e5d-b993-8c6f274b7545 With this change, PHPStan understands the correct class while still forcing classes to extend `Repository`. For example: https://phpstan.org/r/d40317b1-1834-407b-9284-ca1e7b0d3325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current annotations are correct but not complete enough.
Since repositories extend a base class, they can have method that are not in this base class.
The issue with using
Repository<T>as the return type is that PHPStan cannot see those methods.For example: https://phpstan.org/r/65389bf5-b00d-4e5d-b993-8c6f274b7545
With this change, PHPStan understands the correct class while still forcing classes to extend
Repository.For example: https://phpstan.org/r/d40317b1-1834-407b-9284-ca1e7b0d3325
You can try removing the
@extends Repository<Foo>or theextends Repositoryto see the correct errors.