Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secondary HTTPS storage #890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add secondary HTTPS storage #890

wants to merge 1 commit into from
+128 −16

Conversation

gjasny
Copy link
Contributor

@gjasny gjasny commented Jul 11, 2021

No description provided.

@jrosdahl jrosdahl added the feature New or improved feature label Jul 12, 2021
@jrosdahl
Copy link
Member

Looks like a solid implementation.

However, I'm not yet sure that we actually should support HTTPS in this way, so I would like to discuss our options first. See #894.

@gjasny gjasny marked this pull request as draft July 13, 2021 11:02
@gjasny
Copy link
Contributor Author

gjasny commented Jul 13, 2021

Depends on #895

gjasny
gjasny commented Jul 13, 2021
View reviewed changes
test/CMakeLists.txt Outdated Show resolved Hide resolved
@gjasny gjasny marked this pull request as ready for review July 14, 2021 10:18
@jrosdahl jrosdahl mentioned this pull request Jun 26, 2022
Closed
@afbjorklund afbjorklund mentioned this pull request Sep 9, 2022
Open
@afbjorklund
Copy link
Contributor

This needs renaming from "secondary" to "remote"

@jrosdahl jrosdahl mentioned this pull request Nov 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrosdahl jrosdahl jrosdahl left review comments

Assignees
No one assigned
Labels
feature New or improved feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gjasny @jrosdahl @afbjorklund