-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #550 #585
Fix #550 #585
Conversation
Thank you for this contribution! Can you please proof where the original code allowed to match case-insensitive? |
Okay. In this line, it attempts to match using the passed specific name. It catches an |
This does not imply case-insensitivity. It still is case sensitive, but it comapares to either the original variant or the all-uppercase variant. According to SemVer, we cannot change behavior or minor releases. Hence I would propose to split the PR in two: One for the next minor release containing solely the actual bug fix, while all other changes / enhancements should go in a second PR for the next major release. |
I think it is okay to split this PR. I will edit the code to restore the original behaviour and the issue changes case sensitivity will be raised later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please fix the copyright header, so I can merge your contribution. :-)
src/test/java/com/beust/jcommander/converters/EnumConverterTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 👍
This PR fixes #550 and provides a test.
Additionally, I found that the previous version attempts twice to match the upper/lower case version,
so I think it is okay to use
equalsIgnoreCase
.