Allow acceptUnknownOption with variableArity #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarg
requested changes
Oct 7, 2023
There was a problem hiding this comment.
Thank you for your contribution! Unfortunately recent changes to this particular unit test makes it fail once you add the proposed `@Parameters(separators = "=") annotation. Can you please rebase your PR ontop of the master branch and then rework your test accordingly? Thanks! 😃
|
ACK |
VariableArity makes it difficult to decide whether a token belongs to a preceding variableArity Parameter or is a new unknown parameter. This commits makes a variableArity Parameter consume all tokens until it encounters a known option. Fixes: cbeust#377
mkarg
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariableArity makes it difficult to decide whether a token belongs to a preceding variableArity Parameter or is a new unknown parameter.
This commits makes a variableArity Parameter consume all tokens until it encounters a known option.
Fixes: #377