Fixing issue 486 @SubParameter Problems #515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarg
requested changes
Dec 21, 2023
| @@ -300,7 +300,10 @@ private Object handleSubParameters(String value, int currentIndex, Class<?> type | |||
| objectValue = type.newInstance(); | |||
| parameterized.set(object, objectValue); | |||
| } | |||
| boolean access = sai.field.isAccessible(); | |||
| sai.field.setAccessible(true); // before using the field, set accessible to true | |||
There was a problem hiding this comment.
Please provide a unit test for this bug. Thanks.
| @@ -81,6 +81,32 @@ public void addValue(Parameterized parameterized, Object object, Object value, F | |||
| throws IllegalAccessException { | |||
| if (parameter != null) { | |||
| if (field != null) { | |||
| Class<?> fieldClass = field.getType(); | |||
There was a problem hiding this comment.
Please provide a unit test for this bug. Thanks.
| try { | ||
| value = fieldClass.getConstructor(value.getClass()).newInstance(value); | ||
| } catch (InstantiationException | InvocationTargetException | NoSuchMethodException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Please do not print to stack trace, but instead throw ParameterException. Thanks.
|
@fsd654qyl Kindly asking for answers to the open questions. Thanks. |
|
@fsd654qyl Kindly requesting your response! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #486