Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSGi entries in MANIFEST.MF during jar creation #503

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add OSGi entries in MANIFEST.MF during jar creation #503

merged 1 commit into from
Mar 4, 2022

Conversation

adessaigne
Copy link
Contributor

Hello 👋

Here is a fix the issue #502

I'm no Gradle expert, I tried this and it generates the proper OSGi entries. Maybe there's a better way but at least it's a starting point.

Thanks!

@adessaigne
Copy link
Contributor Author

Hello 👋

Do you see a better way to do it? I'll gladly update my pull-request to something better. Thanks!

@adessaigne
Copy link
Contributor Author

Hello @cbeust
I'm sorry to tag you, can you tell me what can I do to help resolving this issue? Thank you 🙇

@adessaigne
Copy link
Contributor Author

Hello @cbeust
Can you have a look at this PR and tell me what I've not done properly if it's the case? I really need OSGi metadata in the manifest.mf file. Thank you.

@cbeust cbeust merged commit 0525445 into cbeust:master Mar 4, 2022
@adessaigne
Copy link
Contributor Author

Thank you for merging it 👍

@adessaigne adessaigne deleted the osgi branch March 7, 2022 09:10
@mkarg mkarg added the build label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adessaigne @cbeust @mkarg