439 expand dynamic arg expands non dynamic args #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarg
requested changes
Dec 21, 2023
npetzall
force-pushed
the
439_expandDynamicArg_expands_nonDynamicArgs
branch
from
be2bc40 to
27de115
Compare
|
Nils, you force-pushed, but the result still is the same. Is this by intention? |
I did so because I'm 5 years after master, so need to get all changes in. |
That's fine, but do you also plan to fix the open issue I raised yesterday? |
|
@mkarg I would gladly solve it, if you could provide me with a way of testing the existing feature so that I can make sure that I'm not breaking it. |
|
Sorry for the delay and thank you very much for your contribution to JCommander, Nils! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #439
When looking the names loop wasn't duplicated in any validating fashion.
So adding a handlesArg method wouldn't improve anything.
Extracting a method might have been nice, but it would require three arguments.