Fixed reading from file when using standard separator (" ") #222
Conversation
TKlerx
force-pushed
the
master
branch
2 times, most recently
from
2f76521 to
f225dda
Compare
pull recent changes from cbeust repo
|
Any comment on accepting or rejecting this pull request? |
|
@TKlerx I know it's been a while but any way to provide a test case for it? |
|
@TKlerx Thank you for your contribution. As @jeremysolarz already said, it would be good having a test case. I need to confess that I do not understand the actual problem just from reading the bug description. Thank you. |
| @@ -38,6 +38,8 @@ | |||
| import java.util.Map; | |||
| import java.util.ResourceBundle; | |||
|
|
|||
| import bsh.classpath.BshClassPath.GeneratedClassSource; | |||
There was a problem hiding this comment.
You are adding an import but you are not referencing it.
| @@ -481,9 +500,9 @@ private static List<String> readFile(String fileName) { | |||
|
|
|||
| try { | |||
| BufferedReader bufRead = new BufferedReader(new FileReader(fileName)); | |||
|
|
|||
There was a problem hiding this comment.
Please remove whitespace added at the end of the line.
| List<String> splitFileArgs = Lists.newArrayList(); | ||
| //special treatment for standard separator (" ") | ||
| String[] v1 = fileArgs.toArray(new String[0]); | ||
| for (int i = 0; i < fileArgs.size(); i++) { |
There was a problem hiding this comment.
Please correct indentation.
| List<String> splitFileArgs = Lists.newArrayList(); | ||
| //special treatment for standard separator (" ") | ||
| String[] v1 = fileArgs.toArray(new String[0]); | ||
| for (int i = 0; i < fileArgs.size(); i++) { |
There was a problem hiding this comment.
Why introducing i instead of simply using for-each?
| if (isOption(v1, arg2)) { | ||
| String sep = getSeparatorFor(v1, arg2); | ||
| if (" ".equals(sep)) { | ||
| String[] sp = arg2.split("[" + sep + "]", 2); |
There was a problem hiding this comment.
Why using sep here instead of static " "?
| for (String ssp : sp) { | ||
| splitFileArgs.add(ssp); | ||
| } | ||
| }else{ |
There was a problem hiding this comment.
Can you please add blanks around else?
|
@TKlerx Kindly requesting your response! :-) |
When specifying a file with parameters and " " as separator, JCommander crashed because the parameters and their values were not split correctly.
This is the (ugly) fix.