Fixed: Default value of primitive type must not satisfy required = true

cbeust · Oct 8, 2023 · a215799 · a215799
1 parent d4b93a6
commit a215799
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/main/java/com/beust/jcommander/JCommander.java b/src/main/java/com/beust/jcommander/JCommander.java
@@ -848,7 +848,7 @@ else if (commands.isEmpty()) {
             // if the parameter has a default value (not the one assigned by DefaultProvider
             // but the one assigned on the variable initialization), make it as assigned and
             // remove it from the list of parameters to be required
-            if (parameterDescription.getDefault() != null) {
+            if (parameterDescription.getDefault() != null && !parameterDescription.getParameterized().getType().isPrimitive()) {
                 fields.get(parameterDescription.getParameterized()).setAssigned(true);
                 requiredFields.remove(parameterDescription.getParameterized());
             }

diff --git a/src/test/java/com/beust/jcommander/DefaultValueTest.java b/src/test/java/com/beust/jcommander/DefaultValueTest.java
@@ -123,5 +123,16 @@ class MyRequiredOptsWithDefaultValues {
     cmd.parse(new String[]{});
   }
 
+  @Test(expectedExceptions = ParameterException.class)
+  public void missingRequiredPrimitiveParameterWithoutDefaultValueMustRaiseParameterException() {
+    class MyRequiredOptsWithDefaultValues {
+      @Parameter(names = "-i", required = true)
+      public int i; // implicit initialization value does not count as a default, so does not satisfy required = true
+    }
+
+    MyRequiredOptsWithDefaultValues opts = new MyRequiredOptsWithDefaultValues();
+    JCommander cmd = new JCommander(opts);
+    cmd.parse(new String[]{});
+  }
 
 }