set evdev key threshold to 0.5 #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Sun, 2022-05-22 at 06:17 -0700, Alesya Huzik wrote:
Hi. Many midi devices that don't have velocity sensitivity usually
send notes with velocity values like 64, 96 or 100 (out of 127). This
means that those keypresses are not recognised by midimonster. 127 is
rarely used as it'd correspond to maximum piano key velocity, which
wouldn't sound musical, unlike less extreme values. This patch sets
the threshold at 0.5 which fixes the problem for my Behringer
Could you just use a simple lua script to make an input "boolean" such
as:
https://github.com/cbdevnet/midimonster/blob/master/configs/returnjustone.lua
… FCB1010. Ideally it'd probably make sense to make the key velocity
threshold configurable, but I'm not the best C programmer to do that.
You can view, comment on, or merge this pull request online
at: #112
Commit Summary * 9743a87 set evdev key threshold to 0.5
* 5f7e733 evdev: update threshold value in the docs
File Changes (2 files)
* M backends/evdev.c (2)
* M backends/evdev.md (2)
Patch Links: * https://github.com/cbdevnet/midimonster/pull/112.patch
* https://github.com/cbdevnet/midimonster/pull/112.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this
thread.Message ID: ***@***.***>
|
|
Please ignore the CI, it is currently not aware of branches that are not master.. |
|
@phedders thanks for the reference. I agree that you can simulate that by using a lua script or other means. This PR is just about better out of the box experience. |
Spacelord09
added
backend
|
Hi, thanks for your effort in improving the MIDIMonster. I'm not sure I understand this PR correctly, your issue seems to be with MIDI Input devices, but the change modifies the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Many midi devices that don't have velocity sensitivity usually send notes with velocity values like 64, 96 or 100 (out of 127). This means that those keypresses are not recognised by midimonster. 127 is rarely used as it'd correspond to maximum piano key velocity, which wouldn't sound musical, unlike less extreme values. This patch sets the threshold at 0.5 which fixes the problem for my Behringer FCB1010. Ideally it'd probably make sense to make the key velocity threshold configurable, but I'm not the best C programmer to do that.