Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-fix: Grouped filters with filterCount%2==0 are flipped #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asydorov
Copy link

We should flip bitmap once instead of flipping scene for every filter in a group.

@linjiansheng
Copy link

linjiansheng commented Aug 25, 2016

@asydorov THX!
GPUImageTwoInputFilter.java also need change:

    public void setRotation(final Rotation rotation, final boolean flipHorizontal, final boolean flipVertical) {
        float[] buffer = TextureRotationUtil.getRotation(rotation, flipHorizontal, flipVertical);

        mTexture2CoordinatesBuffer = ByteBuffer.allocateDirect(TEXTURE_NO_ROTATION.length * 4)
                .order(ByteOrder.nativeOrder())
                .asFloatBuffer();
        mTexture2CoordinatesBuffer.put(buffer).position(0);
    }

TEXTURE_ROTATED_90 is same with iOS GPUImage rotateLeftTextureCoordinates, anticlockwise?

@tbfly
Copy link

tbfly commented Sep 8, 2016

mark

@CLAassistant
Copy link

CLAassistant commented Oct 14, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants