Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tmux-mem-cpu-load status #375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdetweil-amzn
Copy link

  • Add in tmux-mem-cpu-load status
  • update tests to run a simple loop
  • Add documentation.
image

Add in `tmux-mem-cpu-load` status, update tests.
@kjnsn
Copy link
Collaborator

kjnsn commented Oct 16, 2024

Oh this is awesome!!

My only hesitation is that we already have status line segments for CPU usage and for load, so this is duplicating that information. Is is possible to just output the memory usage? I also see that tmux-mem-cpu-load has support for displaying a gradient of colors across the usage bar, it would be great if this could somehow be mapped to the catppuccin red -> lavender spectrum.

@mdetweil-amzn
Copy link
Author

Oh this is awesome!!

My only hesitation is that we already have status line segments for CPU usage and for load, so this is duplicating that information. Is is possible to just output the memory usage? I also see that tmux-mem-cpu-load has support for displaying a gradient of colors across the usage bar, it would be great if this could somehow be mapped to the catppuccin red -> lavender spectrum.

Yes, you do support CPU usage/load. There are two other PRs open about memory, both more or less pointing to this as an implementation option, but they seemed abandoned, and as I already used the tool before porting over to catppuccin/tmux it was an easy enough implementation. Now, I find that what presents the best experience for users is a host of options. I think each of the cpu/mem tools output slightly differently, and that can give a really custom experience.

Maybe what that means is that the structure should start to separate out types of status into consolidated groups for each reading/decision making. With that said it does not appear possible to only output memory usage at this time. I can follow up with a second PR to implement tmux-mem

The --colors flag turns on color support, which by default changes the color based on the load. As for the gradient support, at this time it appears thats only available to powerline users, and it only supports the standard 256 color mode. So those colors are likely out of the picture for the time being.

On a completely separate separate note, I took the time to do a minor refactor of the test runner. I hope that was okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants