Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(home-manager/alacritty): remove the general setting option #450

Merged

Conversation

mariovagomarzal
Copy link
Contributor

Summary

This pull request fixes an issue in the Home-Manager Alacritty module related to the placement of the import config key in the generated alacritty.toml configuration file.

Problem

The current implementation of the Alacritty module defines the import config key as follows:

settings.general.import = lib.mkBefore [ "${sources.alacritty}/catppuccin-${cfg.flavor}.toml" ];

This results in a configuration file with the following structure:

[general]
import = ["..."]

However, according to Alacritty's documentation, global settings like import must be declared at the top level of the TOML file. They should not be nested under a [general] section. The correct structure should be:

import = ["..."]

[other_options]
...

Solution

This pull request modifies the module to define the import config key at the top level by replacing
settings.general.import with settings.import.

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@isabelroses isabelroses merged commit 89bbaf1 into catppuccin:main Jan 4, 2025
@Yakkhini
Copy link
Contributor

Yakkhini commented Jan 5, 2025

Wait maybe this PR has something wrong. In latest version of alacritty's documentation it says the general option should under [general]. The global and root config is previous version of alacritty's convention.

Maybe you're using 0.13.2 version? I think we should follow the new api when there is conflict.

In my machine alacritty claim a warning after recent update.

yakkhini@20250105125207

Ref:
alacritty/alacritty#8192
alacritty/alacritty#8305

Yakkhini added a commit to Yakkhini/nix that referenced this pull request Jan 5, 2025
getchoo pushed a commit that referenced this pull request Jan 5, 2025
…tion" (#452)

Revert "fix(home-manager/alacritty): remove the `general` setting option (#450)"

Refs: 89bbaf1
@mariovagomarzal
Copy link
Contributor Author

You're absolutely right. I seem to have come across the documentation through a link shared in a discussion on this topic and assumed it was the latest version. My bad...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants