-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(home-manager): add support for wezterm #433
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestions do depend on a catppuccin wezterm package.
989e1fa
to
b72c8b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using config.catppuccin.sources.wezterm
will require a package, take a look at https://github.com/catppuccin/nix/blob/main/CONTRIBUTING.md.
b72c8b5
to
e8d22ad
Compare
c441571
to
9512a18
Compare
Eventually with help of search engines and chatbots I was able to make it working. I replaced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, LGTM.
68ae54c
to
cf0402a
Compare
cf0402a
to
6be9577
Compare
Rebased and resolved conflicts |
6be9577
to
6d1b11a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something more like this
Co-authored-by: Isabel <[email protected]>
I updated the code though now it doesn't follow the global |
I think not. Because this will often be a breaking change and its a bit of a strange to use. we do something similar to this for kvantum. |
Okay then, we can update the code once the wezterm module for home manager will be updated to support more than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM
modules/home-manager/wezterm.nix
Outdated
config = wezterm.config_builder() | ||
end | ||
|
||
dofile("${sources.wezterm}/plugin/init.lua").apply_to_config(config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to export this as a variable so it's actually able to be imported in someone's own config, though
Maybe something like
extraConfig = ''
local catppuccin_plugin = "${sources.wezterm}/plugin/init.lua"
''
+ lib.mkIf cfg.apply (lib.mkBefore ''
<...?
'');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, please take a look. Lua isn't my strong side as well as Nix 😅
079da07
to
1091805
Compare
This adds support for WezTerm theme. There are no specific option fo themes in the wezterm home-manager module so I used
extraConfig
.