Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(whiskers): don't reuse version field #17

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

sgoudham
Copy link
Contributor

Sorry I should have caught this in my review but Renovate is currently going a bit crazy because it's detecting version as the whiskers version on both fields.

Simple workaround is to rename it but I'll look into the regex to see if I can improve it in any way to avoid this type of thing going forward.

Copy link
Collaborator

@atticus-sullivan atticus-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sgoudham sgoudham changed the title build(whiskers): don't reuse version string build(whiskers): don't reuse version field Oct 15, 2024
@sgoudham sgoudham merged commit 8d283a1 into main Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants