Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support push event by associating with open pull requests #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tockn
Copy link

@tockn tockn commented Jan 17, 2024

Thank you for the wonderful project! In this Pull Request, I have made changes to allow this action to be triggered by push events as well.

Previously, the action would retrieve pull request information from the context payload and, if present, comment with the results of the metrics. However, this was only possible with pull request events. With this change, if pull request information cannot be obtained from the context, the system now retrieves open pull requests associated with the sha and comments there. This modification allows the action to operate with push events as well.

@serkan-ozal
Copy link
Member

Hi @tockn,

Thanks for your contribution and sorry for late reply. Could you please rebase your PR with latest changes?

@tockn
Copy link
Author

tockn commented Feb 18, 2024

@serkan-ozal Hi! I've resolved the conflicts!

@rwxdash
Copy link
Member

rwxdash commented Mar 4, 2024

Hey @tockn,

Apologies for late reply and slow progress. Can you please rebase again and run npm run all on your local before committing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants