Fix flaky SetTimeoutTest #1080
Closed
Fix flaky SetTimeoutTest #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@JakeWharton Looks like this works around the flaky test issue. Should we merge + add a TODO to figure out the root cause?
Co-authored-by: Colin White <[email protected]>
Co-authored-by: Colin White <[email protected]>
|
I'll look today. I wanted to give a shot at fixing the test first, presumably by moving to |
We generally think this library is not well designed and causes more problems than it solves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #1073
Bit of a weird conundrum though, does
eventuallywork correctly? Debugging it tells me so, but do I test the test code?Any reason why this project don't use Kotest or so?