Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serializer identifier for nested descriptor elements #1077

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

gnawf
Copy link
Contributor

@gnawf gnawf commented Jul 14, 2023

Ran into a problem similar to #1039 but the fix there was not sufficient for my case.

I had the serial names

  • app.cash.zipline.internal.bridge.FlowZiplineCollector<kotlin.collections.ArrayList>

but I needed

  • app.cash.zipline.internal.bridge.FlowZiplineCollector<kotlin.collections.ArrayList<String>>
  • app.cash.zipline.internal.bridge.FlowZiplineCollector<kotlin.collections.ArrayList<Int>>

@JakeWharton
Copy link
Collaborator

Test failure is a known flake (#1073)

Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@swankjesse swankjesse enabled auto-merge (squash) September 14, 2023 21:01
@swankjesse
Copy link
Collaborator

Another flaky test, oh boy.
#1025

@swankjesse swankjesse merged commit ba5ae5f into cashapp:trunk Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants