Set JDK versions when running the compiler frontend #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Jun 28, 2023
| @@ -76,10 +79,10 @@ internal class KotlinFirLoader( | |||
| configuration.put(CommonConfigurationKeys.MODULE_NAME, targetName) | |||
| configuration.put(CLIConfigurationKeys.MESSAGE_COLLECTOR_KEY, messageCollector) | |||
| configuration.put(CommonConfigurationKeys.USE_FIR, true) | |||
| configuration.put(JVMConfigurationKeys.JDK_HOME, javaHome) | |||
| configuration.put(JVMConfigurationKeys.JDK_RELEASE, jdkRelease) | |||
There was a problem hiding this comment.
@JakeWharton setting these two properties satisfies the removed TODO!
This is necessary to load JPMS modules from the JDK. Unfortunately there's no nice API to fetch the JDK version from the Gradle KotlinCompile task. It exposes an API to write this data but not to read it.
swankjesse
force-pushed
the
jwilson.0628.jdk_versions
branch
from
7dcb7a0
to
a54ceb9
Compare
JakeWharton
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to load JPMS modules from the JDK.
Unfortunately there's no nice API to fetch the JDK version from the Gradle KotlinCompile task. It exposes an API to write this data but not to read it.