Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: @ZiplineId #1059

Closed
wants to merge 5 commits into from
Closed

[WIP] feat: @ZiplineId #1059

wants to merge 5 commits into from

Conversation

epicadk
Copy link
Contributor

@epicadk epicadk commented Jun 24, 2023 •
edited
Loading

closes: #1048

@swankjesse
Copy link
Contributor

I’ll take a look at this! But please in the future let us know before you proceed to build features? We’re not actively seeking external contributors.

@epicadk
Copy link
Contributor Author

epicadk commented Jul 4, 2023

Thanks, I think we can close, can't get the new services tests to run. It always throws method not found serviceNamesArray on Zipline.create for some reason.

@epicadk epicadk closed this Jul 4, 2023
@epicadk epicadk deleted the ak/ziplineService/id branch September 4, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@ZiplineId
2 participants
@epicadk @swankjesse